Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Forbidden characters' typo #850

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Fix 'Forbidden characters' typo #850

merged 1 commit into from
Feb 14, 2022

Conversation

emmahodcroft
Copy link
Member

Description of proposed changes

Fixes a typo, correcting forbidden_chactacters (here) to forbidden_characters

Seems this was introduced 2 years ago - thankfully I hope hasn't caused issues since then. However, I actually use

from augur.parse import forbidden_characters

in a number of my scripts & builds (outside of SC2) - so found this bug when running them for the first time since Jan 2020.

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #850 (082bb3e) into master (bdfbe82) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #850   +/-   ##
=======================================
  Coverage   34.27%   34.27%           
=======================================
  Files          41       41           
  Lines        5941     5941           
  Branches     1520     1520           
=======================================
  Hits         2036     2036           
  Misses       3823     3823           
  Partials       82       82           
Impacted Files Coverage Δ
augur/parse.py 62.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdfbe82...082bb3e. Read the comment docs.

@corneliusroemer
Copy link
Member

Oh dear, let's hope no one imports forbidden_chactacters now... To be safe, one could add forbidden_chactacters = forbiidden_characters

It was introduced here: 722d52b in March 2020.

augur/parse.py Show resolved Hide resolved
@huddlej huddlej merged commit 521022d into master Feb 14, 2022
@huddlej huddlej deleted the parse_typo_fix branch February 14, 2022 19:13
@huddlej huddlej added this to the Next release X.X.X milestone Feb 14, 2022
@emmahodcroft
Copy link
Member Author

Thanks all for the speedy feedback and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants