Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. API doc fixes #896

Merged
merged 2 commits into from
May 3, 2022
Merged

Misc. API doc fixes #896

merged 2 commits into from
May 3, 2022

Conversation

joverlee521
Copy link
Contributor

Miscellaneous API doc fixes that came from my dive into rST and the API docs when I was working on the measurements subcommand.

These commits were originally part of #879, but split into this new PR at the request of @huddlej for easier review.

Copy link
Contributor

@huddlej huddlej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing all of these glaring errors, @joverlee521! I noticed one weird parsing issue that remains, but after that's fixed, this is good to merge.

augur/filter.py Show resolved Hide resolved
1. Add an extra line between sections and doctests to correctly
render the doctest blocks
2. Add literal blocks using `::` to preserve formatting of example files
3. Correct `Returns` subtitles
@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #896 (a20a6a2) into master (002c44f) will increase coverage by 0.45%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
+ Coverage   34.62%   35.07%   +0.45%     
==========================================
  Files          42       42              
  Lines        6007     6052      +45     
  Branches     1538     1557      +19     
==========================================
+ Hits         2080     2123      +43     
  Misses       3854     3854              
- Partials       73       75       +2     
Impacted Files Coverage Δ
augur/align.py 88.99% <ø> (ø)
augur/clades.py 33.33% <ø> (ø)
augur/distance.py 48.36% <ø> (ø)
augur/export_v2.py 11.11% <ø> (ø)
augur/filter.py 70.37% <ø> (ø)
augur/io.py 100.00% <ø> (ø)
augur/titer_model.py 19.96% <ø> (ø)
augur/tree.py 13.21% <ø> (ø)
augur/utils.py 50.00% <100.00%> (+6.16%) ⬆️
augur/index.py 63.15% <0.00%> (-1.71%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 002c44f...a20a6a2. Read the comment docs.

@joverlee521 joverlee521 merged commit 9cd6eb4 into master May 3, 2022
@joverlee521 joverlee521 deleted the doc-fixes branch May 3, 2022 23:55
@victorlin victorlin added this to the Next release X.X.X milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants