Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include functional tests in code coverage #899

Merged
merged 3 commits into from
May 24, 2022
Merged

Commits on Apr 21, 2022

  1. Include functional tests in code coverage

    Use the default coverage report file `.coverage` for unit and functional
    tests, running Augur in functional tests through an alias that runs
    coverage in append mode. Then, use the coverage xml command to generate
    the XML report needed by the codecov tool.
    huddlej committed Apr 21, 2022
    Configuration menu
    Copy the full SHA
    723d609 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ebcdfb8 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. Hoist coverage setup out of individual cram test files and into the C…

    …I workflow
    
    This avoids baking in coverage to the tests and lets it remain a
    separate concern (e.g. CI's concern).  In my experience it's better to
    have coverage tracing happen outside of tests (i.e. the tests are
    unaware) rather than as integrated into the tests themselves.
    
    Partially reverts commit 723d609, which
    added code for coverage to each cram test file.
    
    I chose to use the github.workspace context var in the CI workflow so I
    could use the "env:" block for the job step.  Alternatively, we could
    use `realpath` to construct an `env AUGUR=… …` call chaining to the
    `cram …` invocation, but that seemed slightly messier to me.
    tsibley committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    072404e View commit details
    Browse the repository at this point in the history