Update release process #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huddlej
requested changes
May 6, 2022
There was a problem hiding this comment.
This will make life a bit easier for us! As part of this PR, could you also remove references to the "release" branch from the DEV_DOCS and add a link to how to manually rebuild the Docker image (https://github.com/nextstrain/docker-base#rebuilding-an-image-and-pushing-to-docker-hub)?
Running this workflow against TestPyPI followed by PyPI does not work. Publishing to TestPyPI was desirable initially when testing this out, but we ran into some unintended consequences when publishing to TestPyPI during an actual release. On top of publishing as a final step, this workflow also does creates a git commit on master+release and creates a new tag, regardless of which PyPI instance is targeted. So, by running the 15.0.2 release against TestPyPI, the tag is created and a subsequent 15.0.2 release against PyPI would fail. We have already released to PyPI using this so there is not much benefit keeping TestPyPI around anymore.
With the new GitHub Actions release process, this is no longer necessary since any failed tests will prevent tags from pushing. A subsequent run of the workflow will start from a clean slate.
The release process can function fine without a release branch, and he version tags should be sufficient for anyone looking for the latest release in git history. If anything, we can replace the release branch with a git tag which is updated by the release script, but I don't see any immediate need for one.
victorlin
force-pushed
the
victorlin/fix-release
branch
from
b7e2903
to
ebcad79
Compare
huddlej
approved these changes
May 17, 2022
|
Oops, I meant to rebase commits before merging, but no biggie. |
|
The removal of the |
tsibley
added a commit
to nextstrain/docker-base
that referenced
this pull request
May 23, 2022
…ase" branch The "release" branch was recently removed.¹ Instead, use the Git tag for the latest stable version released to PyPI. There's a larger discussion to be had about if it makes any sense any more for Augur to be installed from Git instead of PyPI (and correspondingly, Auspice from NPM), but that's for another time. ¹ nextstrain/augur#913
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Some changes prompted by the release of 15.0.2 – a first using the GitHub Actions workflow, which had some unexpected bumps.
Related issue(s)
N/A
Testing
Unable to test until next release.
Pre-merge
Post-merge
releasebranch