-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
io: Migrate VCF functions from filter+utils to io #929
io: Migrate VCF functions from filter+utils to io #929
Conversation
3b5b2f9
to
17a1d9a
Compare
Codecov Report
@@ Coverage Diff @@
## master #929 +/- ##
==========================================
+ Coverage 59.59% 59.61% +0.02%
==========================================
Files 43 43
Lines 6056 6059 +3
Branches 1550 1550
==========================================
+ Hits 3609 3612 +3
Misses 2188 2188
Partials 259 259
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. These functions always felt odd to have in filter.py
. Since we are moving these functions, I'd slightly prefer to move then into io.py
, to keep them close to other I/O logic.
These functions don't have filtering logic and can be moved next to the existing read_vcf() as a more appropriate scope.
These VCF functions are specifically IO-related utilities, so moving them to a better scope.
17a1d9a
to
4279b66
Compare
Description of proposed changes
See commit messages.
Motivated by work in #854.
Related issue(s)
N/A
Testing
Tests moved accordingly.