Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split codecov into separate job, combine coverage of all matrix jobs #948

Closed

Conversation

victorlin
Copy link
Member

Description of proposed changes

Combining coverage from all matrix jobs is beneficial for any version-dependent code paths.

Originally proposed in #899 (comment).

Related issue(s)

Testing

See CI run.

Combining coverage from all matrix jobs is beneficial for any version-dependent code paths.

Co-authored-by: Thomas Sibley <tsibley@fredhutch.org>
@victorlin victorlin requested a review from a team May 24, 2022 22:27
@victorlin victorlin self-assigned this May 24, 2022
@victorlin victorlin marked this pull request as draft May 24, 2022 22:38
@victorlin
Copy link
Member Author

CI failed on coverage xml:

No source for code: '/home/runner/work/augur/augur/augur/__init__.py'.

Will need to investigate.

@tsibley
Copy link
Member

tsibley commented Jun 14, 2022

I believe I've fixed that issue in #968.

@tsibley tsibley closed this Jun 15, 2022
@victorlin victorlin deleted the ci/separate-codecov-job branch June 15, 2022 21:44
@victorlin victorlin restored the ci/separate-codecov-job branch June 15, 2022 21:44
@victorlin victorlin deleted the ci/separate-codecov-job branch January 6, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

CI: split codecov step out into its own job
2 participants