Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pandas.DataFrame.at instead of .loc for single values #979

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Jun 17, 2022

Description of proposed changes

This is the recommended way by pandas:

Similar to loc, in that both provide label-based lookups. Use at if you only need to get or set a single value in a DataFrame or Series.

Related issue(s)

Testing

No tests added.

@victorlin victorlin requested a review from a team June 17, 2022 22:01
@victorlin victorlin self-assigned this Jun 17, 2022
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Base: 61.64% // Head: 61.64% // No change to project coverage 👍

Coverage data is based on head (740fc85) compared to base (f148234).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #979   +/-   ##
=======================================
  Coverage   61.64%   61.64%           
=======================================
  Files          52       52           
  Lines        6286     6286           
  Branches     1583     1583           
=======================================
  Hits         3875     3875           
  Misses       2139     2139           
  Partials      272      272           
Impacted Files Coverage Δ
augur/export_v1.py 74.35% <100.00%> (ø)
augur/refine.py 63.13% <100.00%> (ø)

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@victorlin
Copy link
Member Author

Merging without review since I think this is a trivial change, and patch coverage is 100% according to #979 (comment).

@victorlin victorlin merged commit f97b1cb into nextstrain:master Aug 15, 2022
@victorlin victorlin deleted the use-pandas-df-at branch August 15, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

1 participant