Merge pull request #1665: Update eslint rules

.eslintignore

@@ -1,3 +1,4 @@
 dist/*
+docs/*
 node_modules/*
-dev-server.js
+webpack.config.js

.eslintrc.yaml

@@ -0,0 +1,48 @@
+---
+extends:
+  - eslint:recommended
+  - plugin:react/recommended
+  - plugin:react-hooks/recommended
+
+plugins:
+  - react
+  - react-hooks
+
+parser: "@babel/eslint-parser"
+
+globals:
+  page: true
+  browser: true
+  context: true
+  jestPuppeteer: true
+  BASE_URL: true
+
+rules:
+  # Code quality rules
+  no-unused-vars: ["error", { "argsIgnorePattern": "^_", "destructuredArrayIgnorePattern": "^_" }]
+  no-use-before-define: ["error", { "functions": false }]
+  prefer-const: ["error", {"destructuring": "all"}]
+  react/no-array-index-key: error
+  react/prop-types: off # Remove this override once all props have been typed using PropTypes or TypeScript.
+
+  # Code style rules
+  arrow-parens: ["error", "always"]
+  no-unneeded-ternary: ["error", { "defaultAssignment": true }]
+  operator-linebreak: ["error", "after", { "overrides": { "?": "ignore", ":": "ignore" } }]
+  quote-props: ["error", "as-needed"]
+
+parserOptions:
+  ecmaVersion: 6
+  sourceType: module
+  ecmaFeatures:
+    modules: true
+
+env:
+  es6: true
+  browser: true
+  node: true
+  jest: true
+
+settings:
+  react:
+    version: detect

cli/server/convertJsonSchemas.js

@@ -169,7 +169,7 @@ const setAuthorInfoOnTree = (v2, meta) => {
  * The feature information was an object with properties `start`, `end` and `strand`
  */
 const convertToGffFormat = (annotations) => {
-  for (const name in annotations) { // eslint-disable-line
+  for (const name in annotations) {
     // Convert from 0-based BED format to 1-based GFF format for start position
     annotations[name].start += 1;
     // half-open 0-based BED end position is the same as 1-based closed ended GFF position.

cli/server/getDataset.js

@@ -2,7 +2,7 @@ const getAvailable = require("./getAvailable");
 const helpers = require("./getDatasetHelpers");
 
 const setUpGetDatasetHandler = ({datasetsPath}) => {
-  return async (req, res) => { // eslint-disable-line consistent-return
+  return async (req, res) => {
     try {
       const availableDatasets = await getAvailable.getAvailableDatasets(datasetsPath);
       const info = helpers.interpretRequest(req, datasetsPath);

cli/server/getNarrative.js

@@ -2,7 +2,6 @@ const queryString = require("query-string");
 const path = require("path");
 const fs = require("fs");
 const utils = require("../utils");
-const marked = require('marked');
 
 const setUpGetNarrativeHandler = ({narrativesPath}) => {
   return async (req, res) => {

cli/utils.js

@@ -2,7 +2,6 @@
 const fs = require('fs');
 const chalk = require('chalk');
 const path = require("path");
-const fetch = require('node-fetch');
 
 const verbose = (msg) => {
   if (global.AUSPICE_VERBOSE) {

cli/view.js

@@ -45,7 +45,7 @@ const loadAndAddHandlers = ({app, handlersArg, datasetDir, narrativeDir}) => {
   if (handlersArg) {
     const handlersPath = path.resolve(handlersArg);
     utils.verbose(`Loading handlers from ${handlersPath}`);
-    const inject = require(handlersPath); // eslint-disable-line
+    const inject = require(handlersPath);
     handlers.getAvailable = inject.getAvailable;
     handlers.getDataset = inject.getDataset;
     handlers.getNarrative = inject.getNarrative;