Merge pull request #1293 from nextstrain/filter-call-stack-size

controls/filter: Avoid spread syntax with potentially large arrays
nextstrain · Feb 26, 2021 · f4fa3fd · f4fa3fd
2 parents 71365f2 + 7f0787a
commit f4fa3fd
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/src/components/controls/filter.js b/src/components/controls/filter.js
@@ -61,11 +61,14 @@ class FilterData extends React.Component {
           });
       });
     if (genotypeSymbol in this.props.activeFilters) {
-      const sortedGenotypes = [...collectGenotypeStates(this.props.nodes)].sort();
-      options.push(...sortedGenotypes.map((o) => ({
-        label: `genotype ${o}`,
-        value: [genotypeSymbol, o]
-      })));
+      Array.from(collectGenotypeStates(this.props.nodes))
+        .sort()
+        .forEach((o) => {
+          options.push({
+            label: `genotype ${o}`,
+            value: [genotypeSymbol, o]
+          });
+        });
     }
     if (strainSymbol in this.props.activeFilters) {
       this.props.nodes