Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frequencies data doesn't reflect accessor #2

Closed
colinmegill opened this issue Jun 1, 2016 · 3 comments
Closed

Frequencies data doesn't reflect accessor #2

colinmegill opened this issue Jun 1, 2016 · 3 comments

Comments

@colinmegill
Copy link
Collaborator

d3.json(path + file_prefix + "frequencies.json", function(error, json){
  console.log(error);
  frequencies = json;
  pivots = frequencies["mutations"]["global"]["pivots"].map(function (d) {
    return Math.round(parseFloat(d)*100)/100;
  });

http://nextstrain.org/data/Zika_frequencies.json

there is no ["mutations"], is this the right request url?

@trvrb
Copy link
Member

trvrb commented Jun 1, 2016

This is an issue with the current zika pipeline. It's not fully estimating frequency trajectories the way the flu pipeline does.

At nextflu.org we show a panel with trajectories:

frequencies

that's not present in the current page at nextstrain.org/zika/. With the full pipeline, there is a frequencies["mutations"] key. Take a look at H3N2_3y_frequencies.json for the full version of what the json should look like.

@rneher
Copy link
Member

rneher commented Jun 1, 2016

I think we should separate entropy from frequencies and have two different files entropy.json and frequencies.json. the latter could then be flat, i.e., {'pivots':[2014,2015,2016,], 'mutation_1':[0.1, 0.2, ...]} (where pivots are values on the x-axis). I would also take the clade frequencies out of the tree (they are easily 500kb). the clade frequencies could simply be added to frequencies.json

@trvrb
Copy link
Member

trvrb commented Jun 4, 2016

I like this suggestion.

jameshadfield pushed a commit that referenced this issue May 25, 2020
@rleir rleir mentioned this issue May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants