Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title of map panel: "Transmissions" -> "Geographic distribution" #743

Closed
rneher opened this issue Jul 18, 2019 · 5 comments
Closed

Title of map panel: "Transmissions" -> "Geographic distribution" #743

rneher opened this issue Jul 18, 2019 · 5 comments

Comments

@rneher
Copy link
Member

rneher commented Jul 18, 2019

For many builds, we don't infer ancestral states. In this case, there are no transmission lines to be displayed and the title of the panel is misleading. I would prefer "Geographic distribution" similar.

@trvrb
Copy link
Member

trvrb commented Jul 18, 2019

Historically, I had wanted the "Transmissions" panel name, because I had thought to make this abstracted from geography. Ie you could place demes in a circle or according to a spring embedding. And in this case you could show things like camel/human transitions in MERS or between genotype transitions in flu. Obviously, this never happened.

I do think I'd prefer a slightly shorter name than "Geographic distribution". How about just "Geography"?

geography

(I also tried "Tree" and "Map" for simplicity, but this looked too informal.)

@rneher
Copy link
Member Author

rneher commented Jul 18, 2019

happy with that. But 'Mao'? 'Lenin'? nvm -- you just corrected to 'Map'...

@jameshadfield
Copy link
Member

jameshadfield commented Jul 18, 2019

Why not both? 😉

Screenshots of toggling geo-resolution in WNV (transmissions only inferred for "state") on branch map-title

image

image

@rneher
Copy link
Member Author

rneher commented Jul 19, 2019

great!

@emmahodcroft
Copy link
Member

Why not both? 😉

Where are gifs in github when you need them!

jameshadfield added a commit that referenced this issue Jul 20, 2019
* map-title:
  Change map title to "Geography" if no transmissions exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants