Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bundlesize checks to CI #1069

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Add bundlesize checks to CI #1069

merged 1 commit into from
Apr 16, 2020

Commits on Apr 16, 2020

  1. Add bundlesize checks to CI 

    This adds a bundlesize check to the CI with very liberal tolerances for most of the chunks. It should identify egregious bundle size expansion and provide an easier path for manual comparison of master vs PRs.

Currently bundlesize doesn't work with GitHub actions out-of-the-box, but this is planned for their roadmap (and they've just got $10k from Google so I'm confident it will happen). Redux-saga seems to have this working via https://github.com/redux-saga/redux-saga/pull/1952/files.

We can revisit the settings here after the chunk hashing #1037.
    @jameshadfield
    jameshadfield committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    9a36ad3 View commit details
    Browse the repository at this point in the history