fix 1176 (Drag and drop tsv metadata not adding color by option to dropdown) #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see github.com//issues/1176#issuecomment-649097216
jameshadfield
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1176 (comment)
Description of proposed changes
Adds a clause to fix this particular issue, but if we are concerned that shouldComponentUpdate might preventing other needed updates in the name of performance improvements (the implementation of that function seemed to make an important performance improvement), maybe there is a way we could get the best of both worlds. For example, by PureComponent to make a shallow comparison of props and state.
Related issue(s)
#1176
#1035
Testing
see #1176 for testing steps to reproduce the bug. Doing this should now achieve the desired behavior in the original issue.
Thank you for contributing to Nextstrain!