Improve parsing of auspice URLs with a colon character #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for new nextstrain.org functionality to allow users to specify custom JSON locations as a URL within the nextstrain.org URL (see nextstrain/nextstrain.org#216) we need to improve the logic auspice uses to identify dual trees. dual trees are defined via <pathA>:<pathB> but we wish to allow a `:` charater inside pathA (and/or pathB) and not interpret this as requesting two trees.
jameshadfield
temporarily deployed
to
auspice-dont-split-data-hctlbj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for new nextstrain.org functionality to allow
users to specify custom JSON locations as a URL within the
nextstrain.org URL (see nextstrain/nextstrain.org#216)
we need to improve the logic auspice uses to identify dual trees.
dual trees are defined via : but we wish to allow a
:characterto appear within pathA (and/or pathB) in the form of "http://" or "https://"
and not interpret this as requesting two trees.