Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve appearance of sidebar headers #1231

Merged
merged 2 commits into from
Nov 19, 2020
Merged

Improve appearance of sidebar headers #1231

merged 2 commits into from
Nov 19, 2020

Conversation

trvrb
Copy link
Member

@trvrb trvrb commented Nov 18, 2020

Using medium gray so it's less prominent on both Auspice's dark sidebar and Nextstrain's light sidebar. We only have a single text color in globalStyles.js and so I hard coded this to the component rather than borrowing something from globalStyles.js.

Using medium gray so it's less prominent on both Auspice's dark sidebar and Nextstrain's light sidebar. We only have a single text color in globalStyles.js and so I hard coded this to the component rather than borrowing something from globalStyles.js.
@jameshadfield jameshadfield temporarily deployed to auspice-styling-jxbbulijpvxqaz November 18, 2020 18:40 Inactive
@jameshadfield jameshadfield temporarily deployed to auspice-styling-jxbbulijpvxqaz November 19, 2020 00:46 Inactive
@jameshadfield
Copy link
Member

Thanks @trvrb -- also added a unrelated line but in the same file which fixes the vertical spacing on safari, where the <div> housing the heading had height of zero!

@jameshadfield jameshadfield changed the title Update sidebar info icon to medium gray Improve appearance of sidebar headers Nov 19, 2020
@trvrb
Copy link
Member Author

trvrb commented Nov 19, 2020

Nice catch James!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants