Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download data improvements #1245

Merged
merged 6 commits into from
Jan 5, 2021
Merged

Download data improvements #1245

merged 6 commits into from
Jan 5, 2021

Commits on Dec 15, 2020

  1. Refactor Download Buttons code

    This splits apart the download modal react component into two: one for the main modal layout, and another for the download buttons. This improves separation and paves the way for improvements to the download buttons. There should be no changes in behavior arising from this commit.
    jameshadfield committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    f6b46f7 View commit details
    Browse the repository at this point in the history
  2. Remap key "d" to open download modal

    Previously this triggered an automatic screenshot (SVG) download, which was dev-only, undocumented functionality that made it into production.
    
    Here we map "d" to open the download modal which is both more expected, and helpful for the current work. This key shortcut can either be removed in this PR or documented and released as-is.
    jameshadfield committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    829ef23 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2020

  1. Downloaded files now represent selected (displayed) data. 1/2

    Previously certain downloaded files (e.g. trees) represented all data, certain files only represented selected (visible) data (e.g. entropy) and some could do both (e.g. there were two metadata buttons).
    
    This commit moves to having all buttons behave in a consistent manner -- if the data is subsetted (filtered, zoomed etc) then only the visible nodes will be part of the download.
    
    All file exports _except_ trees are updated in this commit.
    jameshadfield committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    021df4c View commit details
    Browse the repository at this point in the history
  2. Downloaded files now represent selected (displayed) data. 2/2

    (See previous commit message for context).
    
    Exported trees now represent the visible (and in-view) tree.
    
    Note that exported trees of filtered datasets often contain nodes higher (more ancestral) than the expected root. This is the bug reported in #1240.
    jameshadfield committed Dec 16, 2020
    Configuration menu
    Copy the full SHA
    9681c1f View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. Allow NEXUS export with all colorings included as annotations

    Similar to current Newick export except in a format conforming with BEAST such that it can be read by FigTree.
    jameshadfield committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    9f3561f View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Downloaded tree units represent current view

    This makes behavior consistent with the idea that downloaded data represents the current view. It also prevents a bug when trying to download a temporally scaled tree for a non-temporal dataset.
    jameshadfield committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    0b0c01b View commit details
    Browse the repository at this point in the history