Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filters to hide ancestral nodes before last common ancestor #1248

Closed
wants to merge 2 commits into from

Commits on Dec 19, 2020

  1. Update filters to hide ancestral nodes before last common ancestor

    Before this commit, filters determined visibility by:
    1. Finding all terminal nodes in view window that match the filters and
    mark them as visible.
    2. Recursively marking all parent nodes of these terminal nodes visible,
    all the way up to the root of the tree.
    
    This commit adds an additional step to hide ancestral nodes before
    the last common ancestor of visible terminal nodes. Starting from
    the root of the tree, recursively hide each node if it does not have
    more than one child node that is visible.
    joverlee521 committed Dec 19, 2020
    Configuration menu
    Copy the full SHA
    2332920 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2020

  1. Rename function hideNodeIfOnlyONeChildVisbile

    Renamed to `hideNodesAboveVisibleCommonAncestor` to be clearer purpose
    of the function.
    joverlee521 committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    727d87a View commit details
    Browse the repository at this point in the history