Legend no longer obscures branches/tips. #1302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shifts the top of the tree down slightly so that tips and branches cannot be hidden behind the (closed) legend, which prevents interacting with them. This only happens in rectangular / unrooted trees, as radial / clock views almost never have tips rendered in the top-left corner.
trvrb
approved these changes
Mar 10, 2021
|
This looks great to me. I think this can be merged. Testing suggests that 6px is a good amount of padding for this purpose. |
|
Late to the party but this looks great @jameshadfield ! While this is a bit of a rare case, certainly for me it's come up more often when looking at smaller clusters in 'divergence' view - if they're identical at the base, it's not uncommon to get some up in the top-left! So this will be very handy in those cases 😁 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shifts the top of the tree down slightly so that tips and branches cannot be hidden behind the (closed) legend, which prevents interacting with them. This only happens in rectangular / unrooted trees, as radial / clock views almost never have tips rendered in the top-left corner.
Note that the horizontal position of the tips in this screenshot has been changed for testing purposes
This PR is a trade off -- we reduce the available display space for all (rectangular & unrooted) trees to prevent the (rare) cases of tips being rendered in the top-left corner and thus obscured by the legend. A more intelligent solution would be to make
mapToScreen()aware of when tips are rendered behind the legend and only increase the margin in this case.Closes #1295