Styling adjustments to footer text #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nextstrain.org deployment looks like it worked as expected: https://nextstrain-s-auspice-pr-6i41bz.herokuapp.com/ncov/global?dmin=2021-05-17&r=division |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This is a simple update to the CSS styling of the page footer specified in
footer.js. This is motivated by display of long Markdown description inopenbuilds. Here is resulting display prior to this update:And here is the resulting display after this update:
I don't think the main paragraph text was ever meant to be slightly bold. It has
font-weight: 300specified underFooterStyles. However, because it wasn't specified underpthe main paragraph text was getting set asfont-weight: 400.I borrowed the font sizing in the section headers from bedford.io, where I preferred to give more of a dynamic range compared to default CSS. In this case, I thought the
#####to be much too large without providing the styling.Testing
Tested locally.