Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inactivate tips when no longer focused #1372

Merged
merged 1 commit into from
Jul 15, 2021
Merged

Inactivate tips when no longer focused #1372

merged 1 commit into from
Jul 15, 2021

Conversation

jameshadfield
Copy link
Member

Selecting a tip (and the corresponding info panel modal) is intrinsically linked to setting a single active "sample" filter. When clicking away from this modal the filter was removed.

This caused issues in the situation where "a tip is selected under a filter, then you click on that tip to see more information, when you click away to close the box, the filter is removed."

The solution here is to inactivate the sample filters when removing the info panel. This has the benefit (bug?) of keeping a history of clicked tips in the form of inactive filters. (Note that all strain filters can be removed by a single click in the sidebar filter badge.)

Closes #1357

@emmahodcroft could you test this out? There are alternative (harder) solutions where we keep track of whether a clicked tip was previously an inactive filter or not if we want to pursue that. However this PR, in conjunction with #1371, could potentially make @eharkins & Moira's job easier via the following workflow:

  1. Click on every outlier tip. Each click will open a tip-info panel, so click outside of that to remove it each time.
  2. Notice that all the clicked tips are now inactive filters
  3. Click on the "eye" icon in the filter badge in the sidebar for "samples", which will make all these inactive sample filters active.

Selecting a tip (and the corresponding info panel modal) is intrinsically linked to setting a single active "strain" filter. When clicking away from this modal the filter was removed.

This caused issues in the situation where "a tip is selected under a filter, then you click on that tip to see more information, when you click away to close the box, the filter is removed."

The solution here is to inactivate the strain filters when removing the info panel. This has the benefit (bug?) of keeping a history of clicked tips in the form of inactive filters. (Note that all strain filters can be removed by a single click in the sidebar filter badge.)

Closes #1357
@jameshadfield jameshadfield temporarily deployed to auspice-tip-filters-ursw0bm0kt July 9, 2021 03:23 Inactive
@emmahodcroft
Copy link
Member

I've just played around with this and I think it's a nice solution. It's easy to clear them out if you aren't interested in them, or to just remove one if it turns out you are 'making a list' but you don't want to include that one. Plus, in combo with #1371 it'll be super easy to then flick them on and off to zoom & investigate further.

However, happy to wait and see what Eli & Moira think since they're on the 'opposite' end of the checking than I usually am!

@jameshadfield jameshadfield merged commit 13d13af into master Jul 15, 2021
@jameshadfield jameshadfield deleted the tip-filters branch July 15, 2021 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on filtered tips, then away, means they're removed from filter
2 participants