Drag-n-drop metadata shows in second tree #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reducer was previously responding to a whole range of actions even if there was no second tree! There were enough checks in the code that this didn't result in bugs, but it's conceptually simpler to avoid trying to modify the second tree when it doesn't exist!
Tips present only in the second tree will be correctly coloured, and appear in the legend. However there are two (long-standing) bugs / shortcomings related to the second tree which are relevant here: 1. Trait values which only appear in tips in the second tree will not be available as filtering options (they will be correctly shown on the tree and in the legend, however). 2. The tip-counts, as they appear in the header, only consider the main (left) tree. For instance, if you have a metadata CSV with information on 100 tips in the left tree, and 150 tips in the right tree (and 100 are in both), and you filter to the strains which appear in the dropped CSV (the colouring is the same name as the file). The header will now indicate "Showing 100 of XXX genomes", despite the fact that all 150 strains in the second tree are displayed. Both of these bugs are not specific to drag-n-drop metadata, the same situations happen with any colouring / filter. Closes #1488
|
This is really fantastic James, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips present only in the second tree will be correctly coloured, and
appear in the legend. However there are two (long-standing) bugs /
shortcomings related to the second tree which are relevant here:
Trait values which only appear in tips in the second tree will not be
available as filtering options (they will be correctly shown on the tree
and in the legend, however).
The tip-counts, as they appear in the header, only consider the main
(left) tree. For instance, if you have a metadata CSV with information
on 100 tips in the left tree, and 150 tips in the right tree (and 100
are in both), and you filter to the strains which appear in the dropped
CSV (the colouring is the same name as the file). The header will now
indicate "Showing 100 of XXX genomes", despite the fact that all 150
strains in the second tree are displayed.
Both of these bugs are not specific to drag-n-drop metadata, the same
situations happen with any colouring / filter.
Closes #1488