Reenable tree confidence intervals #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we checked for the presence of num_date confidence on the first node (nodes[0]). Prior to auspice handling subtrees (arrays of trees), nodes[0] was guaranteed to be the root node, but this is no longer the case. Checking a single node wasn't the best approach anyway as we should check for _any_ node with confidence set, which this commit now does.
nextstrain-bot
temporarily deployed
to
auspice-bug-date-confid-yfygzu
|
Tested using the review app via slack |
|
Thanks so much James! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we checked for the presence of temporal confidence intervals on the first node (nodes[0]). Prior to auspice handling subtrees (arrays of trees), nodes[0] was guaranteed to be the root node, but this is no longer the case. Checking a single node wasn't the best approach anyway as we should check for any node with confidence set, which this commit now does.