Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch labels don't capture click events #1584

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

jameshadfield
Copy link
Member

There is currently no on-hover behavior for branch labels and they have a tendency to obscure branches behind them and make them un-clickable.

Closes #1580

There is currently no on-hover behavior for branch labels and they
have a tendency to obscure branches behind them and make them
un-clickable.

Closes #1580
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-bug-branch-labe-tgqj2r October 23, 2022 21:50 Inactive
Copy link
Contributor

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Love it when a bug can be fixed with a single CSS change!
I didn't realize that none pointer-events worked like this!

In addition to indicating that the element is not the target of pointer events, the value none instructs the pointer event to go "through" the element and target whatever is "underneath" that element instead.

@jameshadfield jameshadfield merged commit 3d9a4f2 into master Oct 24, 2022
@jameshadfield jameshadfield deleted the bug/branch-label-clickthrough branch October 24, 2022 22:47
@corneliusroemer
Copy link
Member

This works well indeed, just tested ;)

Is there a master deploy by nextstrain-bot @jameshadfield? I had quite some trouble building master locally so any preview would be very handy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Labels make branch covered by it unclickable
4 participants