Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measurements paper improvements #1631

Merged
merged 5 commits into from
Feb 7, 2023
Merged

Commits on Feb 1, 2023

  1. measurements: Make x-axis sticky

    Uses "sticky" positioning to make sure the x-axis is always visible even
    when the SVG overflows the container. The main SVG's position has been
    changed to "relative" to shift up the bottom based on the x-axis height.
    joverlee521 committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    595c1e8 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. measurements: Allow multiple thresholds

    The measurements panel now expects each collection to have an array of
    threshold values.
    
    This change is backwards compatible because single value thresholds are
    converted to an array during the loading of the measurements JSON.
    Note `collection.thresholds` takes precedence over the deprecated
    `collection.threshold`, so the single value will be ignored if
    `collection.thresholds` exists.
    
    All threshold values will be displayed as solid grey lines across the
    subplots. The toggle for showing thresholds applies to all threshold
    values. Future improvements include allowing customizations of
    solid vs dashed lines and individual toggles for each threshold.
    joverlee521 committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    21573a9 View commit details
    Browse the repository at this point in the history
  2. measurements: Jitter y-value for raw measurements within color-by groups

    For each subplot, jitter the y-values of the raw measurements within
    each color-by group. The y-value range for each color-by group is
    determined by the proportion of measurements within each group, i.e.
    color-by groups with more measurements get a larger portion of the
    subplot height.
    
    Removes the jitter value added during loading of the measurements JSON
    and the `measurementJitterSymbol` since they are no longer needed.
    joverlee521 committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    c8e16a1 View commit details
    Browse the repository at this point in the history
  3. measurements: change opacity of raw measurements

    Testing to see if lowering the opacity of the raw measurement circles
    can help with visualizations of denser areas of the plots.
    joverlee521 committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    ece5f2a View commit details
    Browse the repository at this point in the history
  4. measurements: reset container scroll on redraw

    Restores the behavior prior to adding the sticky x-axis where the
    container resets to the top when the SVG is redrawn.
    
    This explicit reset fixes the issue where the sticky x-axis can
    potentially leave the panel in a scrolled state that displays a
    huge white space.¹
    
    ¹ #1631 (comment)
    joverlee521 committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    e2794b5 View commit details
    Browse the repository at this point in the history