Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop node14, update testing #1674

Merged
merged 2 commits into from
Jun 25, 2023
Merged

Drop node14, update testing #1674

merged 2 commits into from
Jun 25, 2023

Commits on Jun 23, 2023

  1. Remove support for Node.js version 14 

    Node.js v14 went from LTS to end-of-life status on 2023-04-30¹.

Both of our internal consumers of auspice (auspice.us, nextstrain) use
node v16.

This commit parallels 402828c (2023-03-03) which removed support for
node v12.

¹ https://github.com/nodejs/release#release-schedule
    @jameshadfield @victorlin
    jameshadfield authored and victorlin committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    15969de View commit details
    Browse the repository at this point in the history

  2. Update puppeteer and jest-puppeteer 

    As recommended by `npm audit`

The removal of the line in `puppeteer.setup.js` was motivated by the
introduced error "TypeError: page._client.send is not a function". I'm
reasonably confident that line was related to integration tests
removed in a previous commit.

Note that this version of puppeteer uses nullish coalescing assignment
which is not supported by node.js v14.
    @jameshadfield @victorlin
    jameshadfield authored and victorlin committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    cd0f21e View commit details
    Browse the repository at this point in the history