Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CleanWebpackPlugin with output.clean #1733

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

victorlin
Copy link
Member

The built-in option is available starting with webpack 5.20.0.¹ It's also recommended in the output management guide.²

¹ https://webpack.js.org/configuration/output/#outputclean
² https://webpack.js.org/guides/output-management#cleaning-up-the-dist-folder

The built-in option is available starting with webpack 5.20.0.¹ It's
also recommended in the output management guide.²

¹ <https://webpack.js.org/configuration/output/#outputclean>
² <https://webpack.js.org/guides/output-management#cleaning-up-the-dist-folder>
@victorlin victorlin self-assigned this Dec 28, 2023
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-victorlin-webpa-t1oyi3 December 28, 2023 01:42 Inactive
Copy link
Member

@jameshadfield jameshadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested by adding some files to ./dist and verifying that they were removed when auspice was built.

@victorlin victorlin merged commit 97589d1 into master Jan 8, 2024
20 checks passed
@victorlin victorlin deleted the victorlin/webpack-output branch January 8, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants