Restore terminal branch hover/click behaviour #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
auspice-james-fix-termi-hpwj8a
jameshadfield
force-pushed
the
james/fix-terminal-muts
branch
from
6207630
to
9e3df93
Compare
nextstrain-bot
temporarily deployed
to
auspice-james-fix-termi-hpwj8a
Hovering on terminal branches incorrectly displayed tip-specific information rather than branch-specific. This was first noticed in <#1752> as the mutations are summarised differently for branches vs nodes. This bug was introduced in 86b8527 and this commit reverts some of the changes introduced there. Closes the original issue described in <#1752>, but comments in that issue also identified a separate bug related to the branch-click modal.
Clicking on terminal branches incorrectly behaved as if we had clicked on the tip (the circle); the intended behaviour is for internal + terminal branches to summarise the information the same way. This was noticed in an issue comment <#1752 (comment)> The bug was introduced in f7e944d which removed the ability to detect if a click occurred on a terminal node (tip) or terminal branch.
jameshadfield
force-pushed
the
james/fix-terminal-muts
branch
from
9e3df93
to
325f6ff
Compare
nextstrain-bot
temporarily deployed
to
auspice-james-fix-termi-hpwj8a
jameshadfield
changed the title
With the changes in the previous commit we no longer need the `isTerminal` argument, as we use the (more accurate) `isBranch` property. This removes the console errors "trying to remove values from an un-initialised filter!" when shift-clicking on a branch then removing the info modal. The bug was introduced by #1749.
jameshadfield
force-pushed
the
james/fix-terminal-muts
branch
from
325f6ff
to
e6c461c
Compare
nextstrain-bot
temporarily deployed
to
auspice-james-fix-termi-hpwj8a
|
Merging without review (see #1752 for context). Post-merge review welcomed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1749 (released in version 2.52.0) inadvertently removed the distinction between terminal branches and tips, which resulted in hovering or shift-clicking on terminal branches showing the wrong information. The intended behaviour (restored here) is to summarise the changes on the branch, whereas hovering/clicking on the tip shows information about the specific strain and collects all mutations between the tip and the tree root.
Closes #1752