Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scatterplots work with temporal YYYY-MM-DD scales #1836

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

jameshadfield
Copy link
Member

Closes #1835

This code would be greatly enhanced by using TypeScript

  • Checks pass
  • If making user-facing changes, add a message in CHANGELOG.md summarizing the changes in this PR
  • (to be done by a Nextstrain team member) [Create preview PRs on downstream repositories][1].

@jameshadfield
Copy link
Member Author

@huddlej you can see your (formerly broken) example at https://nextstrain-s-nextstrain-smwbzp.herokuapp.com/staging/rabies/YYYY-MM-DD-coloring?l=scatter&scatterX=date&scatterY=div

src/util/scatterplotHelpers.js Outdated Show resolved Hide resolved
Closes #1835

This code would be greatly enhanced by using TypeScript
@jameshadfield jameshadfield temporarily deployed to auspice-james-yyyy-mm-d-juejcf August 28, 2024 20:44 Inactive
@huddlej
Copy link
Contributor

huddlej commented Aug 29, 2024

Nice! Thanks, @jameshadfield!

@jameshadfield jameshadfield merged commit 35a0fa1 into master Aug 29, 2024
26 checks passed
@jameshadfield jameshadfield deleted the james/yyyy-mm-dd-scatterplots branch August 29, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temporal scales don't work in scatterplots
4 participants