Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changeDateFilter now dispatches only once. Closes #385 #389

Merged
merged 1 commit into from
Jul 11, 2017
Merged

Conversation

jameshadfield
Copy link
Member

@jameshadfield jameshadfield commented Jul 11, 2017

please test before merge

using console.log statements, only 1 dispatch is being seen by the reducers, and only one lifecycle (ComponentDidUpdate, ComponentWillReceiveProps) of map is running:

SET INTERVAL START
reducers seeing  CHANGE_DATES_VISIBILITY_THICKNESS
map CWRP
map CDU
SET INTERVAL END (stack may not be clear)

Given the redux architecture and that animation uses the dispatch + react architecture to update things at each tick, I think this is the best we can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant