Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix control display for "divergence". Closes #382. #399

Closed
wants to merge 3 commits into from
Closed

Fix control display for "divergence". Closes #382. #399

wants to merge 3 commits into from

Conversation

sidneymbell
Copy link
Contributor

No description provided.

@trvrb
Copy link
Member

trvrb commented Jul 17, 2017

Thanks for this Sidney. However, running from divergenceDefaultDisplay I'm still getting issue #382. "TIME" starts out highlighted and then when the JSONs load, it deselects, but "DIVERGENCE" is not highlighted.

dengue

@sidneymbell
Copy link
Contributor Author

Thanks, Trevor. Sorry, I totally missed this somehow. It's fixed now.

@sidneymbell sidneymbell requested a review from trvrb July 28, 2017 17:14
@trvrb
Copy link
Member

trvrb commented Aug 3, 2017 •
edited
Loading

This was superseded by PR #416. Thanks for identifying and fixing the bug @sidneymbell.

@trvrb trvrb closed this Aug 3, 2017
@trvrb trvrb deleted the divergenceDefaultDisplay branch August 3, 2017 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trvrb trvrb Awaiting requested review from trvrb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidneymbell @trvrb