Precalculate deme and transmission data #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With commit 515e78a, Ebola is now running |
|
I think this is now good to go. @colinmegill could I request a review here? Please merge if you're satisfied or go ahead and make fixes. I'm not going to have much more a chance to work on this in the next few days. |
|
Read through all of this, this looks really great. Merging now. Exciting to have smarter updates here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #392
This creates
demeDataandtransmissionDatain map state. These are flat objects listing every deme (there may be duplicates due to west and east triplication) and every transmission event. These are constructed on first load and then only updated on update operations (change color, change date slider, etc...).Performance is roughly comparable at the moment. I'm getting 8ms for
updateDemeAndTransmissionDatafor Ebola compared to 18ms onmaster. Large additional speed improvements could be gained from switching from arrays to dictionaries. However, this will complicate things I think best left until after Bezier (#381).This is mostly working, but there's more to do here.