use react performance tools for animation ticks (dev only) #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@jameshadfield --- I think this is an excellent addition. However, I'm not sure I agree with this always displaying on map animation when in dev mode. There will be times when we're debugging map etc... and don't want this. Why not just add a simple |
|
@trvrb think this is good to go now |
|
Thanks James! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds code which will console log the time spend in different components for one animation frame and cumulative for 10 once the play button is clicked. Resets when the animation resets.
Only loaded on the dev version.
@colinmegill please check you are happy with this code being in master.