Vaccines crosses #490
Merged
Vaccines crosses #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jameshadfield. I'm testing this now (along with the augur commit nextstrain/augur@187b8f7. |
|
Though can I request styling that more closely matches nextflu? Both for the clade labels and for the vaccine crosses? |
|
I will do vaccine crosses similar - clade labels is another task! |
|
merging in now (style updates most welcome). Note that no datasets currently have the vaccine data in the meta JSON. |
|
Thanks for implementing this @jameshadfield. I just pushed updated JSONs to data.nextstrain.org, so this now loads on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the crosses over the vaccine strains and provides their dates in the hover / click info panels. It looks in the
meta.jsonfor the presence ofvaccine_choiceswhich i've just added to augur. If this is not present, no vaccine information is displayed.Styling:
Available to view here: https://auspice-dev.herokuapp.com/flu/h3n2/ha/3y -> staging server toggle. (The initial colorBy is black I think because you are developing augur or because I don't run with titers)