Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow negative dates, y labels, better spacing #610

Merged
merged 3 commits into from
Aug 4, 2018
Merged

Conversation

rneher
Copy link
Member

@rneher rneher commented Aug 3, 2018

This fixes the long-standing issue #483 and other non-documented problems with the tree grid. It now allows

  • negative dates (yes, there were pathogens before Christ)
  • adds ylabels indicating divergence in the clock display. This could use some tweaking
  • improves the spacing of grid lines
  • removes the decimal points from dates like 2015.0 (unless major grid resolution is <1y).

@jameshadfield
Copy link
Member

Looks great -- thanks @rneher

I added some comments and cleaned up the code a bit in c7393ea

And then I added horizontal grid lines for clock-layouts in 289add4. If this isn't a good direction to go, i'll remove the commit before merging into master.

screen shot 2018-08-04 at 13 52 49

@rneher
Copy link
Member Author

rneher commented Aug 4, 2018

great. I think the horizontal grid lines are useful.

@trvrb
Copy link
Member

trvrb commented Aug 4, 2018

I really like the horizontal grid lines for clock display. This labeling makes clock display much less opaque.

@trvrb
Copy link
Member

trvrb commented Aug 4, 2018

Actually... I'm getting a bug where if I toggle back and forth between "rectangular" and "clock" the horizontal grid lines will appear in front of the tree.

grid-lines

@jameshadfield jameshadfield merged commit 78f737a into master Aug 4, 2018
@jameshadfield jameshadfield deleted the fix_grid branch August 4, 2018 21:27
@jameshadfield
Copy link
Member

jameshadfield commented Aug 4, 2018

Ahhh merged without seeing that message! I'll fix the bug now. Update: see #612

jameshadfield added a commit that referenced this pull request Aug 4, 2018
By storing references to <g> elements, we don't have to create new ones upon updates. This also preserves the initial ordering of groups, avoiding bugs such as #610 (comment)
@jameshadfield jameshadfield mentioned this pull request Aug 4, 2018
jameshadfield added a commit that referenced this pull request Aug 4, 2018
By storing references to <g> elements, we don't have to create new ones upon updates. This also preserves the initial ordering of groups, avoiding bugs such as #610 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants