Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hot reloading. #677

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Fix hot reloading. #677

merged 1 commit into from
Nov 1, 2018

Conversation

jameshadfield
Copy link
Member

Requires running npm install as dependencies have changed

Requires running `npm install` as dependencies have changed
@jameshadfield jameshadfield changed the title Fix hot reloading. Upgrade webpack. Closes #496 Fix hot reloading. Nov 1, 2018
@jameshadfield
Copy link
Member Author

Can someone (@tsibley @emmahodcroft @trvrb) test that this still works for them?

npm run build && npm run server and npm run dev (You'll need to do npm install first)

@tsibley
Copy link
Member

tsibley commented Nov 1, 2018

The commands work for me as expected (prod server doesn't hot-reload, dev server does).

The dev server does issue this warning:

(node:10421) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead

which doesn't happen on master.

@tsibley tsibley self-requested a review November 1, 2018 18:59
@jameshadfield
Copy link
Member Author

Great. Thanks.

@jameshadfield jameshadfield merged commit 9ac4244 into master Nov 1, 2018
@jameshadfield jameshadfield deleted the updates branch November 1, 2018 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants