Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix initial slider render #713

Merged
merged 2 commits into from
Apr 17, 2019
Merged

Fix initial slider render #713

merged 2 commits into from
Apr 17, 2019

Commits on Apr 16, 2019

  1. Fix slider initial render bug 

    This was caused by the _handleResize method updating internal component state causing a rerender. This rerender wasn't being picked up by React reconciliation properly (I couldn't figure out why). The slider never needs to adjust responsively, and having this responsive adjustment was triggering unnecessary component rerenders during app use. Here, I removed _handleResize and manually set slider width parameters.
    @trvrb
    trvrb committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    765fec9 View commit details
    Browse the repository at this point in the history

  2. Linting pass on Slider

    @trvrb
    trvrb committed Apr 16, 2019
    Configuration menu
    Copy the full SHA
    d78f40b View commit details
    Browse the repository at this point in the history