Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top level meta #769

Merged
merged 3 commits into from
Aug 14, 2019
Merged

Top level meta #769

merged 3 commits into from
Aug 14, 2019

Conversation

joverlee521
Copy link
Contributor

This should close issue #755

  • Update server conversion v1 -> v2 to use top level "meta" layer.
  • Update createMetadatStateFromJSON to use "meta" key

@joverlee521
Update example v2 JSON with top level meta layer
ae2e31d
@joverlee521
Update server conversion to top level meta layer
a55f4f4 
Match v2 JSON schema of using a top level meta layer to 
enclose all metadata.
@joverlee521
Update func: createMetadataStateFromJSON
c3d0205 
Update to use top level meta layer of v2 JSONs for 
creating metadata state.
@jameshadfield jameshadfield merged commit daaa237 into v2 Aug 14, 2019
@jameshadfield jameshadfield deleted the top-level-meta branch August 14, 2019 22:49
@joverlee521 joverlee521 mentioned this pull request Aug 15, 2019
Closed
@cmlsn cmlsn mentioned this pull request Apr 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jameshadfield jameshadfield jameshadfield approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joverlee521 @jameshadfield