read (& send) JSONs as streams where possible #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v2 JSONs are designed so that no modifications need to be made by the server. This allows us to read as a stream and stream the response, saving memory on the server.
|
Awesome! |
huddlej
approved these changes
Nov 25, 2019
tsibley
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: The auspice server (and the nextstrain.org server, but that's not part of this PR) read JSON data into memory during
getDatasetrequest handling and then send the data as a response to the client. For all non-v1 JSONs these data are passed through unmodified by the server.This PR shifts to reading in data as a stream and piping this data to the response (which is also a stream). This results in some nice memory savings (green vs orange lines):
_H3N2 datasets, all v2 JSONs, no tip-frequencies_