Styling changes #849
Styling changes #849
Conversation
When using grid view with a globally distributed pathogen on a laptop display, the previous min zoom level of 2 could include all datapoints.
To have GISAID iFrame, we're supposed to hide the sidebar. It would be nice to have this as a general flag in the URL (like grid, etc...), but I thought this was a fine solution for the intermediate term.
GISAID wanted attribution displayed on hover. They were requesting Originating Lab and Submitting Lab. This is my attempted compromise.
|
Hi @trvrb -- out of curiosity, what was the motivation for hiding the sidebar if the window path contains |
|
@dpark01 --- This was at the request of GISAID to make https://www.gisaid.org/epiflu-applications/next-hcov-19-app/ work nicely via an iFrame. They link to https://nextstrain.org/ncov/gisaid, which is exactly https://nextstrain.org/ncov except dropping the title. We didn't mean for this to catch things like https://auspice.broadinstitute.org/sars-cov-2/boston/gisaid-4k. We should narrow down the regex URL match. I think we may have added "hide sidebar" to the query params anyway and this may be able to fully dropped at this point in favor of GISAID adding this "hide sidebar" request to their iFrame. |
|
Hi @trvrb just wondering if there were any updates on being able to narrow down the regex URL match for paths containing gisaid? thanks! |
This PR does:
gisaidauthorin the tip hover panel(2) Should be revisited to allow sidebar state in the URL, but I think this is a good solution for the time being.