Narrative: explore data & leave narrative #881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the narrative page is the MainDisplayMarkdown, we don't have any data, so hide the "Explore the data yourself" button.
jameshadfield
temporarily deployed
to
auspice-narrative-explo-hzpqu6
jameshadfield
requested changes
Feb 1, 2020
There was a problem hiding this comment.
@joverlee521 -- thanks for this. Works great for non-mobile, but needs to be added to the mobile view (i.e. your fix in narratives/index.js needs to also be here: https://github.com/nextstrain/auspice/blob/master/src/components/narrative/MobileNarrativeDisplay.js#L64.
Clicking on "Leave the narrative & explore the data yourself" completely leaves the narrative and goes to the dataset page.
joverlee521
force-pushed
the
narrative-explore-data-button
branch
from
d172a9a
to
cd5cf77
Compare
jameshadfield
temporarily deployed
to
auspice-narrative-explo-hzpqu6
|
Works well, thanks @joverlee521. If we ever want to revisit this, since the data is already loaded we should be able to show the dataset view & modify state via the JSON-set defaults without needing to reload the entire page. But this would only be a minor improvement & would require more complex code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #871