Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move filtering/subsampling docs into this project #198

Merged
merged 5 commits into from
May 1, 2024

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Apr 25, 2024

Description of proposed changes

Moving to this project prevents fetching another external doc and makes for a cleaner split between augur filter reference and guide.

Related issue(s)

Checklist

  • Preview looks good
  • Checks pass
  • Post-merge: Remove snippet from augur filter docs, replacing it a with a link to this new page (PR)

For consistency with other files in this project.

Retain separate indent sizes for code blocks.
For consistency within this file.
For consistency with other files in this project.
The external reference is no longer necessary now that the contents are
in this project.
@victorlin victorlin requested a review from a team April 25, 2024 18:48
@victorlin victorlin self-assigned this Apr 25, 2024
victorlin added a commit to nextstrain/augur that referenced this pull request Apr 25, 2024
More context can be found in the PR that copied this snippet into the
new location: <nextstrain/docs.nextstrain.org#198>
@victorlin
Copy link
Member Author

victorlin commented Apr 30, 2024

Thanks for reviewing, @genehack! I'll wait for @tsibley's review since this spurred from our discussion in nextstrain/augur#1431.

@victorlin victorlin requested a review from tsibley April 30, 2024 18:40
Copy link
Member

@tsibley tsibley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok by me!

Were you going to add cross-linking to specific options later? Or did you decide to punt on that part?

@victorlin
Copy link
Member Author

victorlin commented May 1, 2024

I figured the existing link to augur filter would be sufficient for now. I'll create an issue for it in the Augur repo: nextstrain/augur#1458

@victorlin victorlin merged commit 6464665 into master May 1, 2024
4 checks passed
@victorlin victorlin deleted the victorlin/update-filtering-subsampling-docs branch May 1, 2024 18:08
victorlin added a commit to nextstrain/augur that referenced this pull request May 1, 2024
More context can be found in the PR that copied this snippet into the
new location: <nextstrain/docs.nextstrain.org#198>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants