Switch from monthly → weekly grouping for 2m builds #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as draft until trial runs succeed and preview links are ready. |
victorlin
force-pushed
the
victorlin/use-weekly-grouping-for-2m
branch
from
93e48da
to
2bb094a
Compare
corneliusroemer
approved these changes
Nov 2, 2022
|
Looks good to me. Definite improvement. Thank you Victor! |
--min-date 2M + --group-by month has funny interactions. For example, if the current date is 3/15, the min date would be 1/15. The monthly grouping would over-sample the partial months (1/15-1/31 and 3/1-3/15) compared to the full middle month. Weekly grouping minimizes this over-sampling to just 2 partial weeks out of 8 or 9 weeks.
victorlin
force-pushed
the
victorlin/use-weekly-grouping-for-2m
branch
from
2bb094a
to
e747ab8
Compare
Use date formats and empty line in between entries to be consistent with entries from recent versions.
victorlin
force-pushed
the
victorlin/use-weekly-grouping-for-2m
branch
from
e747ab8
to
081485d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
--min-date 2M+--group-by monthhas funny interactions. For example, if the current date is 3/15, the min date would be 1/15. The monthly grouping would over-sample the partial months (1/15-1/31 and 3/1-3/15) compared to the full middle month. Weekly grouping minimizes this over-sampling to just 2 partial weeks out of 8 or 9 weeks.Preview staging builds
Related issue(s)
Related to #957 (funny interactions originally mentioned there)
Testing
Release checklist
If this pull request introduces backward incompatible changes, complete the following steps for a new release of the workflowN/AIf this pull request introduces new features, complete the following steps:
docs/src/reference/change_log.mdin this pull request to document these changes by the date they were added.