Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub action to run tests #671

Closed
wants to merge 3 commits into from
Closed

Conversation

jameshadfield
Copy link
Member

@jameshadfield jameshadfield commented Jun 23, 2021

This workflow was originally implemented as part of #668, but I've split it into a separate PR to debug the failing tests. (Note that tests pass locally on my machine.)

Observed failures (so far...)

  • The remote-inputs-uncompressed test uses the input data/references_metadata.tsv and the following (seemingly stochastic) error was observed on GitHub runner:
python3 scripts/sanitize_metadata.py  --metadata data/references_metadata.tsv   ...
Traceback (most recent call last):
...
_csv.Error: Could not determine delimiter
  • The remote-inputs-compressed has filtering steps which remove all sequences, thus causing a test failure.

  • If the AWS keys are not needed, then we should remove them from the workflow. Note that AWS_DEFAULT_REGION: us-east-1 is needed when running on GitHub actions.

jameshadfield and others added 3 commits June 24, 2021 10:42
With the upcoming availability of GenBank intermediate files,
this provides documentation of which assets are uploaded,
to where, and how to start builds from these files.
Document and test remote inputs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants