Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor auspice config and add description.md #24

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Refactor auspice config and add description.md #24

merged 2 commits into from
Jul 1, 2024

Conversation

genehack
Copy link
Contributor

@genehack genehack commented Jun 28, 2024 •
edited
Loading

Description of proposed changes

  • Consolidates auspice_config.json down to 1 file (from 4), with additional changes to ensure titles remain correct
  • Adds description.md file and uses it when generating Auspice JSONs

Related issue(s)

#22
#23

Checklist

  • Checks pass

@genehack
Refactor auspice_config.json handling [#22]
638d575 
* Consolidate down to a single config file at
  `phylogenetic/config/auspice_config`
* Strip the `title` param out of that file
* Generate unique `title` param in `export` rule, and pass that title
  to `augur export`
genehack added a commit that referenced this pull request Jun 28, 2024
@genehack
Add description file with standard attributions [#24]
f8758da
@genehack genehack force-pushed the refactor-auspice-and-add-description-22-24 branch from 2e57870 to f8758da Compare June 28, 2024 22:45
@genehack genehack requested a review from a team June 28, 2024 23:09
joverlee521
joverlee521 requested changes Jun 28, 2024
View reviewed changes
Copy link

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should leave out the "Underlying data" section until those files actually exist 😅

phylogenetic/config/description.md Outdated Show resolved Hide resolved
phylogenetic/config/description.md Outdated Show resolved Hide resolved
@joverlee521 joverlee521 mentioned this pull request Jun 29, 2024
Open
@jameshadfield jameshadfield changed the title Refactor auspice and add description.md Refactor auspice config and add description.md Jul 1, 2024
genehack added a commit that referenced this pull request Jul 1, 2024
@genehack
Add description file with standard attributions [#24]
5525ca8
@genehack genehack force-pushed the refactor-auspice-and-add-description-22-24 branch from f8758da to 5525ca8 Compare July 1, 2024 19:31
genehack added a commit that referenced this pull request Jul 1, 2024
@genehack
Add description file with standard attributions [#24]
7006f59
@genehack genehack force-pushed the refactor-auspice-and-add-description-22-24 branch from 5525ca8 to 7006f59 Compare July 1, 2024 19:35
@genehack genehack force-pushed the refactor-auspice-and-add-description-22-24 branch from 7006f59 to f64d50e Compare July 1, 2024 22:06
@genehack genehack merged commit 20dd267 into main Jul 1, 2024
5 of 6 checks passed
@genehack genehack deleted the refactor-auspice-and-add-description-22-24 branch July 1, 2024 22:11
@j23414 j23414 mentioned this pull request Jul 2, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trvrb trvrb trvrb left review comments

@joverlee521 joverlee521 joverlee521 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@genehack @trvrb @joverlee521