Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingest-to-phylogenetic GitHub Action... [#14] #34

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

genehack
Copy link
Contributor

...to fully automate ingest and subsequent rebuild of phylogenetic when data has changed. Includes related configuration updates, as follows:

  • copy github action and associated build-configs from template
  • customize nextstrain-automation/config.yaml files for ingest and phylogenetic builds
  • add custom file loading to top-level Snakefiles in ingest and phylogenetic builds
  • update .gitignore to ignore newly-used phylogenetic/data
  • update phylogenetic/defaults/config.yaml to remove unused keys
  • update values of various metadata and sequences inputs/outputs in subsidiary 'phylogenetic/rules/*.smk' files

Description of proposed changes

Related issue(s)

Checklist

  • Checks pass

@genehack genehack linked an issue Jul 22, 2024 that may be closed by this pull request
Copy link

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the use of pathogen-repo-build workflow requires adding the pathogen to our list of supported pathogens. See nextstrain/infra docs on how to add a new pathogen

.github/workflows/ingest-to-phylogenetic.yaml Outdated Show resolved Hide resolved
ingest/build-configs/nextstrain-automation/config.yaml Outdated Show resolved Hide resolved
@genehack
Copy link
Contributor Author

Note the use of pathogen-repo-build workflow requires adding the pathogen to our list of supported pathogens. See nextstrain/infra docs on how to add a new pathogen

👍 this is on my list/radar

@genehack
Copy link
Contributor Author

Fixed both sets of file name / bucket key name issues

@genehack
Copy link
Contributor Author

Note the use of pathogen-repo-build workflow requires adding the pathogen to our list of supported pathogens. See nextstrain/infra docs on how to add a new pathogen

Done in nextstrain/infra#27

...to fully automate `ingest` and subsequent rebuild of `phylogenetic`
when data has changed. Includes related configuration updates, as
follows:

* copy github action and associated build-configs from template
* customize nextstrain-automation/config.yaml files for `ingest` and
  `phylogenetic` builds
* add custom file loading to top-level Snakefiles in `ingest` and
  `phylogenetic` builds
* update .gitignore to ignore newly-used `phylogenetic/data`
* update phylogenetic/defaults/config.yaml to remove unused keys
* update values of various `metadata` and `sequences` inputs/outputs
  in subsidiary 'phylogenetic/rules/*.smk' files
@genehack
Copy link
Contributor Author

Note the use of pathogen-repo-build workflow requires adding the pathogen to our list of supported pathogens. See nextstrain/infra docs on how to add a new pathogen

👍 this is on my list/radar

This was applied via a PR in the infra repo.

Application:

Apply complete! Resources: 4 added, 1 changed, 0 destroyed.

@genehack genehack merged commit 22ccbe9 into main Jul 24, 2024
6 checks passed
@genehack genehack deleted the automate-updates-14 branch July 24, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate updates
2 participants