Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move accession to the first column of metadata_all.tsv #36

Merged
merged 2 commits into from
Feb 24, 2024
Merged

Move accession to the first column of metadata_all.tsv #36

merged 2 commits into from
Feb 24, 2024

Commits on Feb 23, 2024

  1. Move accession to the first column of metadata_all.tsv 

    During the merge of Usvi data and GenBank data, the accession field ended
up as the last column. This caused confusion as the first column was named
"genbank_accession" which could be mistaken for the strain ID.

This commit moves the "accession" column to the first column such that
"accession" and "genbank_accession" are next to each other; hopefully,
providing clarity that "accession" is being used as the strain ID, while
"genbank_accession" can be used to generate a url to the NCBI GenBank record
if provided.
    @j23414
    j23414 committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    b68a6aa View commit details
    Browse the repository at this point in the history

  2. Document the notable columns in merging USVI and GenBank data 

    In cases like this where a column name is ambiguous ('accession' and 'genbank_accession'),
bring this context out of commit messages/PRs and into the code itself.
    @j23414
    j23414 committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    3631e90 View commit details
    Browse the repository at this point in the history