Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TechnologyPlatform an ontology term #174

Merged
merged 3 commits into from
Aug 17, 2023
Merged

Make TechnologyPlatform an ontology term #174

merged 3 commits into from
Aug 17, 2023

Conversation

HLWeil
Copy link
Member

@HLWeil HLWeil commented Aug 14, 2023

And add helper functions to parse to and from string representation in isa-json
closes #162

@HLWeil HLWeil changed the base branch from main to developer August 14, 2023 08:43
Freymaurer
Freymaurer requested changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@Freymaurer Freymaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All non basic tests use only term name in ontology annotation. Might be good to do one with a full OA.

@HLWeil HLWeil merged commit 3d666dc into developer Aug 17, 2023
2 checks passed
@HLWeil HLWeil deleted the technologyPlatform branch September 5, 2023 07:49
@HLWeil HLWeil mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Freymaurer Freymaurer Freymaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Make "Assay Technology Platform" a ontology term
2 participants
@HLWeil @Freymaurer