Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize isa sheet name parsing #180

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Standardize isa sheet name parsing #180

merged 2 commits into from
Sep 6, 2023

Conversation

HLWeil
Copy link
Member

@HLWeil HLWeil commented Sep 5, 2023

Sheetnames were inconsistent:

  • now writes isa_investigation; instead of Investigation
  • now reads isa_investigation & deprecated Investigation, fails for other names; instead of reading the first sheet no matter the name

Did some renaming and restructuring of ISA.Spreadsheet project

closes #179

Copy link
Collaborator

@Freymaurer Freymaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code cleanup with tests. Thats the good stuff 🚀

@Freymaurer Freymaurer merged commit 2748e05 into developer Sep 6, 2023
2 checks passed
@HLWeil HLWeil deleted the isa_spreadsheet branch September 7, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants