Skip to content

Commit

Permalink
Tests: unbreak tests for nginx built with AWS-LC.
Browse files Browse the repository at this point in the history
Similar to BoringSSL, AWS-LC doesn't support TLSv1.3 server-side session
cache, and lacks SSL_get_negotiated_group() and SSL_get_shared_ciphers().
  • Loading branch information
pluknet committed Sep 25, 2024
1 parent 1ce06f1 commit 52bf350
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion h3_ssl_early_data.t
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ $s = Test::Nginx::HTTP3->new(8980, psk_list => $psk_list, early_data => {});
TODO: {
local $TODO = 'no 0-RTT in OpenSSL compat layer'
unless $t->has_module('OpenSSL [.0-9]+\+quic')
or $t->has_module('BoringSSL')
or $t->has_module('BoringSSL|AWS-LC')
or $t->has_module('LibreSSL');

$frames = $s->read(all => [{ sid => 0, fin => 1 }]);
Expand Down
2 changes: 1 addition & 1 deletion h3_ssl_session_reuse.t
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ is(test_reuse(8943), 1, 'tickets reused');
is(test_reuse(8944), 1, 'tickets and cache reused');

local $TODO = 'no TLSv1.3 session cache in BoringSSL'
if $t->has_module('BoringSSL');
if $t->has_module('BoringSSL|AWS-LC');

is(test_reuse(8945), 1, 'cache shared reused');
is(test_reuse(8946), 1, 'cache builtin reused');
Expand Down
2 changes: 1 addition & 1 deletion mail_ssl_session_reuse.t
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ is(test_reuse(8994), 1, 'tickets and cache reused');

TODO: {
local $TODO = 'no TLSv1.3 session cache in BoringSSL'
if $t->has_module('BoringSSL') && test_tls13();
if $t->has_module('BoringSSL|AWS-LC') && test_tls13();

is(test_reuse(8995), 1, 'cache shared reused');
is(test_reuse(8996), 1, 'cache builtin reused');
Expand Down
4 changes: 2 additions & 2 deletions ssl.t
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ TODO: {
local $TODO = 'no TLSv1.3 sessions in LibreSSL'
if $t->has_module('LibreSSL') && test_tls13();
local $TODO = 'no TLSv1.3 sessions ids in BoringSSL'
if $t->has_module('BoringSSL') && test_tls13();
if $t->has_module('BoringSSL|AWS-LC') && test_tls13();

like(get('/id', 8085, $ctx), qr/^body \w{64}$/m, 'session id reused');

Expand All @@ -228,7 +228,7 @@ unlike(http_get('/id'), qr/body \w/, 'session id no ssl');
like(get('/cipher', 8085), qr/^body [\w-]+$/m, 'cipher');

SKIP: {
skip 'BoringSSL', 1 if $t->has_module('BoringSSL');
skip 'BoringSSL', 1 if $t->has_module('BoringSSL|AWS-LC');

like(get('/ciphers', 8085), qr/^body [:\w-]+$/m, 'ciphers');

Expand Down
2 changes: 1 addition & 1 deletion ssl_session_reuse.t
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ is(test_reuse(8444), 1, 'tickets and cache reused');

TODO: {
local $TODO = 'no TLSv1.3 session cache in BoringSSL'
if $t->has_module('BoringSSL') && test_tls13();
if $t->has_module('BoringSSL|AWS-LC') && test_tls13();

is(test_reuse(8445), 1, 'cache shared reused');
is(test_reuse(8446), 1, 'cache builtin reused');
Expand Down
2 changes: 1 addition & 1 deletion ssl_sni_sessions.t
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ plan(skip_all => 'no TLSv1.3 sessions, old IO::Socket::SSL')
plan(skip_all => 'no TLSv1.3 sessions in LibreSSL')
if $t->has_module('LibreSSL') && test_tls13();
plan(skip_all => 'no TLS 1.3 session cache in BoringSSL')
if $t->has_module('BoringSSL') && test_tls13();
if $t->has_module('BoringSSL|AWS-LC') && test_tls13();

$t->plan(6);

Expand Down
2 changes: 1 addition & 1 deletion stream_ssl_session_reuse.t
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ is(test_reuse(8444), 1, 'tickets and cache reused');

TODO: {
local $TODO = 'no TLSv1.3 session cache in BoringSSL'
if $t->has_module('BoringSSL') && test_tls13();
if $t->has_module('BoringSSL|AWS-LC') && test_tls13();

is(test_reuse(8445), 1, 'cache shared reused');
is(test_reuse(8446), 1, 'cache builtin reused');
Expand Down

0 comments on commit 52bf350

Please sign in to comment.