Reduce reloads #362
Merged
Reduce reloads #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaachawley
added
the
enhancement
pleshakov
approved these changes
Sep 6, 2018
- batch handling for mergable ingresses - error collection and logging
- Most of the error handling in these batch update funcs can be removed. The caller only logs the errors anyway. - Fix a few rebase issues.
isaachawley
force-pushed
the
reduce-reloads
branch
from
120adcd
to
74645a2
Compare
pleshakov
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the number of reloads for endpoint changes by batching the ingresses to be updated, writing the config files and (in the case of Plus) updating UpstreamServers via the API, before finally reloading NGINX at the end.